fix(submitter): submit_batch/2 crashed on every call (MatchError)#48
Merged
Conversation
handle_call({:submit_batch, ...}) matched the inner
handle_call({:submit, ...}) against a bare {:ok, id, result}, but that
call returns a GenServer {:reply, {:ok, id, result}, state} 3-tuple — so
submit_batch/2 raised MatchError for any non-empty issue list, taking down
the Submitter GenServer. Destructure the reply payload instead.
The pre-existing test 'submit_batch/2 batch submission processes multiple
issues' now passes; full suite green (139 tests, 0 failures).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
hyperpolymath
marked this pull request as ready for review
July 9, 2026 08:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
FeedbackATron.Submitter.submit_batch/2— a public API — raisedMatchErroron every call with a non-empty issue list, crashing theSubmitterGenServer.handle_call({:submit_batch, ...})maps over issues and matches the innerhandle_call({:submit, ...})against a bare{:ok, id, result}. Buthandle_callreturns a GenServer{:reply, {:ok, id, result}, state}3-tuple — so the match always failed.Found while running the suite during pipeline work (the existing test
submitter_test.exssubmit_batch/2 batch submission processes multiple issueswas red).Fix
Destructure the reply payload:
{:reply, {:ok, id, result}, _new_state} = handle_call(...).Verification
Previously-failing test now passes; full suite green (139 tests, 0 failures).
🤖 Generated with Claude Code